Async fix for "Generate values for PK properties that are also self-referencing FK properties" #29134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #22585, #22573, #26448
Async code pat was not fixed in original PR. However, this was not exposed until additional bug fix for #26448 in EF7 RC2
Description
Using the async overload of
Add
fails to generate a key value for TPT mappings where the primary keys of sub-tables are also foreign keys to the main table.Customer impact
Exception when using
AddAsync
in many TPT scenarios.How found
Found while writing samples for EF7.
Regression
Yes; worked in EF Core 6.0.
Testing
Added more use of
AddAsync
in tests.Risk
Low; async code path was missing a check that existed in the sync code path.